forked from AyaseCore/mod-ahbot
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selling of items with zero value as buy/sell price #113
Draft
kewinrausch
wants to merge
12
commits into
azerothcore:master
Choose a base branch
from
kewinrausch:busaroth
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…right in the new source files
…mand line (cleanup and initialization of new elements)
…ces (right now is a plain average which resets to allow quick convergence with the markets sentiments)
… a random pickup, which can always result in bad rolls and waste of cycles, the selling priority now follows the items rarity. First the bot will try to fill up poor items, and then when quotas are reached it will move to more rare ones
… set up for selling/buying, using the item level as a base reference
Can you keep this PR on hold until I put the new mechanism under configuration? |
…be switched on and off
Here we go, this is the version that can be evaluated/tested. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
Issues Addressed:
SOURCE:
Tests Performed:
How to Test the Changes:
AuctionHouseBot.SellerWhiteList="2672, 769, 3173, 2673, 5503, 2674, 2675, 1015 3685, 3731, 3712, 12184, 12205, 12207, 35562, 12208, 20424, 2447, 765, 2450, 2453, 785, 3820, 3357, 3356, 3821, 3355, 8838, 3358, 8831, 8836, 8839, 13464, 13465, 22785, 22789, 2770, 2771, 2775, 2772, 2776, 3858, 7911, 10620, 2589, 2592, 4306, 4338, 14047, 6338, 11128, 11144, 16206, 10940, 11083, 11137, 11176, 16204, 10998, 11082, 11134, 11135, 11174, 11175, 22445, 2318, 783, 2319, 4232, 4234, 4235, 4304, 8169, 8170, 8171"
Vision dust
is not available to be sold at an acceptable price.